question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Using "signAndEditExecutable": false and "verifyUpdateCodeSignature": false will disable icon

See original GitHub issue
  • Electron-Builder Version: 23.0.3
  • Node Version: 16.14.2
  • Electron Version: 19.0.4
  • Electron Type (current, beta, nightly): current
  • Target: Windows

If you are using

"signAndEditExecutable": false,
"verifyUpdateCodeSignature": false,

the electron-builder ignores any icon specified in electron-builder.json, resulting in app using the native app icon instead of specified one. This is probably not intended behavior(disabling code signing in electron-builder should not disable app icon).

To reproduce issue you can use this project.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5

github_iconTop GitHub Comments

2reactions
VanDenycommented, Jul 29, 2022

Maybe friendly ping @mmaietta so this doesn’t just go by?

0reactions
mmaiettacommented, Sep 13, 2022

Editing the executable is the only way to apply an icon, which is paired heavily with signing logic flow.

Happy to review a PR that decouples them, but it seems like it’s a very complex flow that I’m not familiar with.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Any Windows Target - electron-builder
AppX package can be built only on Windows 10. To use Squirrel.Windows please install electron-builder-squirrel-windows dependency. icon = build/icon.ico ...
Read more >
Can't Add Icon To Electron App With Electron Builder
In this project, I'm saving the icons in the project root directory ... the project structure that is working with this build configuration....
Read more >
Options | electron-packager
If true , disables printing informational and warning messages to the console when packaging the application. This does not disable errors. Defaults to...
Read more >
salt.states.win_shortcut - Salt Project Documentation
Allows for the configuration of icons and hot keys on file shortcuts. Changing the icon and hot keys are unsupported for url shortcuts....
Read more >
System tray icons wrong show/no-show toggles
Windows 10 Home, my system tray icons are wonky. Some will go missing on me, not visible at all, not even in the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found