Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] Include package-lock.json

See original GitHub issue

Describe the bug

Adding the package-lock.json file to the .gitignore is probably not what users of the template expect. Essentially, an Electron app is an application, and not a library. And with an application, one definitely wants to be able to recreate it anytime.

However, if there’s not package-lock.json, it’s possible that some dependencies change, and suddenly, the previously-working application cannot be built anymore.

Issue Analytics

State:
Created a year ago
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

caoxiemeihaocommented, Jul 19, 2022

You are right, you can submit a PR to remove *.lock from .gitignore.

0reactions

caoxiemeihaocommented, Jul 19, 2022

putting *.lock in .gitignore is more useful to prevent the *.lock file from being carried when submitting PR.

Top Results From Across the Web

[BUG] package-lock.json not updated with new dependencies ...

As a workaround to (un)install a package I currently delete all node_modules folders, delete the root package-lock.json , run npm install , and ......

package-lock.json -- how to fix version error - Stack Overflow

Turns out I needed to both delete the node_modules and package-lock.json. Doing only one of the two didn't work.

A Few Interesting Bits About package-lock.json. #yesReally

The purpose of the package-lock.json is to let every developer on a repo have the same package tree, meaning each developer has the...

Do I really need package-lock.json file? | by Shani Dar - Medium

Running npm install will generate\update package-lock.json file, which enables to lock all versions for the entire dependency tree. Use npm install to add...

package-locks - npm Docs

As of npm@5.7.0 , these conflicts can be resolved by manually fixing any package.json conflicts, and then running npm install [--package-lock-only] again. npm ......