Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`setupIcon` causes weird installer error messages.

See original GitHub issue

This is an odd one. Built my windows installer on a macOS machine with setupIcon set causes the installer to display weird errors, despite successfully completing. This is reproducible 100% of the time in my case.

Versions:

macOS: 10.11.5
node: v6.1.0
electron: v1.1.1
wine: 1.8.2
winetricks: 20160219 - sha1sum: 34401938dff575bbac6e19d62d0658c88a3ae502
mono: 4.2.3.4

Code to build:

 import { createWindowsInstaller } from 'electron-winstaller'

  let resultPromise = createWindowsInstaller({
    appDirectory: config.getBuildSubDir('windows'),
    outputDirectory,
    authors: 'Exodus Movement Pte Ltd',
    exe: 'Exodus.exe',
    description: config.PACKAGE.description,
    iconUrl: 'https://www.exodus.io/favicon.ico',
   // if this is commented, no errors
    setupIcon: path.join(__dirname, '../../static/icons/ICO/exodus-icon.ico'),
    // setupExe: 'InstallExodus.exe'
    loadingGif: path.join(__dirname, '../../static/gifs/exodus-installer.gif')
  })

The install build process completes without any problems.

When installing the app on Windows, this error pops up twice:

screen shot 2016-07-21 at 9 08 12 pm

and contains a link to this: https://support.microsoft.com/en-us/kb/2715633 that has the following info:

Shim errors for the .NET Framework version and platform support

Error: “You must enable the .NET Framework from the Windows Features dialog box”

This issue occurs because the app is not configured in a way that makes it possible to determine the appropriate version of the .NET Framework runtime. The corresponding shim code is SHIM_GOTO_CONTROLPANEL.

So I am assuming that maybe in the process of setting the icon, maybe other PE resources are getting destroyed that may indicate .NET version? IDK, but it’s odd. Regardless though, the install still produces the desired outcome… links on desktop, start menu, installed to %LocalAppData, etc.

There are no errors in SquirrelSetup.log.

Any ideas? Thanks.