Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature suggestion - Common interface for road objects

See original GitHub issue

As we agree, using objects of type Obstacle isn’t meaningful and convenient for goals. Also, the Obstacle class inherits from Vehicle and contains a massive amount of unnecessary overload.

Here is my suggestion for the new interface:

Common properties:

position
shape (we can stick with rectangular for now)
heading_angle (for rotation ability)
dimensions (length and width for rectangle, radius for circle)
lane
road

Common methods:

make_on_lane()

Some inherited classes can be Obstacle and Landmark(or Goal).

I suggest refactoring check_collision() method the way that it checks intersections with Landmark instances regardless of the COLLISION_ENABLED property.

Please feel free to add your thoughts to complete the idea.

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

eleurentcommented, Jun 13, 2020

Yes, good point thank you!

1reaction

eleurentcommented, Apr 28, 2020

Please do, I’ll review the pull request and make changes if necessary.

Top Results From Across the Web

Why Do You Need To Know Interface Fundamentals?

An interface allows efficient means of generalizing attributes. It allows communicating affordances instead of having to consider the many types ...

Feature Toggles (aka Feature Flags) - Martin Fowler

In this article on Feature Toggling we'll start off with a short story showing some typical scenarios where Feature Toggles are helpful.

On-Road Evaluation of In-vehicle Interface Characteristics and ...

Objective:This study investigated the impact of in-vehicle interface characteristics on drivers' multitasking performance measures relating to visual ...

Enhanced Object Tracking - Cisco

The Enhanced Object Tracking feature separates the tracking mechanism ... To provide a common interface to tracking clients, route metric ...

java - Should I create interfaces for data transfer objects?

The general answer is no, because you should never add code without having a specific, concrete reason for it, and there is no...