get_absolute_url for topic and posts

When I send notification to a poster and I would like to include a link to the post itself. However, there is no get_absolute_url defined for the Topic or Post models. Is there any reason they are not defined?

https://github.com/ellmetha/django-machina/blob/421b7da7d19087e143da5ab165e22ca43251bb28/machina/apps/forum_conversation/urls.py#L36-L41

looks like a good url for Topic, but there is no similar view_post url.

[ellmetha]

I really do not understand why get_absolute_url() was removed because it provides a natural Django way to refer to the forum, topic, or post without the long reverse(slug, pk, slug, pk) calls. Yes it means “presentation-related things in model”, it means server side rendering and might not work well with RESTful or SPA, but as a Django app it is natural to provide them and leave it to users on how to use them (and ABSOLUTE_URL_OVERRIDES is one way to override it).

Well, I think I explicitly stated in my previous message why it was removed: to improve separation of concern. 🙂 There is no need to debate whether or not having this method defined in models is a good or bad practice in general: I already stated that I was open to see it reintroduced.

[BoPeng]

https://github.com/ellmetha/django-machina/commit/905f23a1f2a4eb64b282191778522fd83f9ca7d7 might not apply cleanly but all needed changes appear to be there.

I really do not understand why get_absolute_url() was removed because it provides a natural Django way to refer to the forum, topic, or post without the long reverse(slug, pk, slug, pk) calls. Yes it means “presentation-related things in model”, it means server side rendering and might not work well with RESTful or SPA, but as a Django app it is natural to provide them and leave it to users on how to use them (and ABSOLUTE_URL_OVERRIDES is one way to override it).

I have added these to my extended Topic class and might submit a PR when I get some time. Adding get_absolute_url is trivial but it takes more time to use it consistently throughout the project.