Master branch fixes
See original GitHub issueThere was some functionality that I wanted to use, primarily the ability to delay the execution of a step and trigger functionality prior to a step. This lead me to your master branch, I appreciate it is a work in progress but i wanted to feed back the few minor updates I needed to make to get it suitable for my use.
Fork and branch can be found here: https://github.com/tarqu1n/reactour/tree/temp-bug-fixes
Changes
- Fixed functionality that starts the tour at a specific step - 6deb977e0145c5c10cbff5bc99fa7a02fdb636d3
- Ensure tour step dialog starts centered when the tour starts but does not attempt to center between other steps when the ‘actionBefore’ function is used to pause step execution. 2d04fc04d8effc72d78868891ac9408f6f76b1fc
- Remove use of
checkFnAndRun
helper script as there were scoping issues with its execution. 9e374360fff679cd619ea8f7b131f0617484a860
Looking forward to the master branch being finished.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Basic Branching and Merging - Git SCM
If you need to pull it in, you can merge your master branch into your iss53 branch by running git merge master ,...
Read more >How to fix a Git master branch after accidently merging the ...
Solution 1: Revert the revert. You can revert R on master or an auxiliary branch that you derive from master. Then you merge...
Read more >Git tip: A quicker, smarter way to merge fixes with the master
This blogpost will explain how you can speed up the process of merging your fixes with the master branch(es) of your projects.
Read more >Git — fix commits mistakenly pushed to master branch - Medium
We are going to merge master into feature branch (again), and then make a second revert commit there. ... The fix is done...
Read more >Git: How to replace the master branch - Skofgar's Blog
Replace the main “master” branch with the “fixed “branch using: git push origin +fixed:master. Depending on what your remote repository is ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I didn’t set a default
startStep
, have now updated this:https://github.com/elrumordelaluz/reactour/pull/210/commits/bd164efceaae3d79cb01467665a7acbb110a1183
yup! thanks @tarqu1n
Now I have to found time to work and close the issues related on
actionBefore
(how to cancelasync
stuff, etc.) and updatereadme
to let know people thatmaster
branch is not published yet.Thanks again!