Standardize code "style" across packages

We are using a variety of code styles (var naming, function declaration, modularization) across our packages. We should take stock of the different styles and as a team choose a general code style and update our packages to match.

This will be three phases:

1. Go through code (ts/tsx files in particular) and take not of the different styles we use
   • variable naming conventions (eg camelCase vs underscore)
   • how we declare functions (functionName() {} vs functionName = () => {})
   • how we break up and spread out code across files in a package
2. Meet as a team and decide which methodology we want to use for each styling
3. Go through the code and update to match the chosen styling.

[ajbozarth]

Once #296 is merged we can start work on this

[ajbozarth]

Update from my inital work and discussion in scrum today:

• Based on jupyterlab we will not lint on camelCase and will just do our best to always use it since there are jupyterlab vars we utilize that use underscore vars.
• Our current code uses “function expressions” 99% of the time already and so I will be adding that check to the lint and fixing the few deviations. This does not address the “apparent” issue though, as detailed below.
• Function expressions can be written a few ways:
  • static myfunctionName(): void { } will make a function can be called as UtilClass. myfunctionName() by importing the containing UtilClass
  • myfunctionName(): void { } which can be called within a class with this.myfunctionName()
  • private myfunctionName = (): void => { } which can be called locally as myfunctionName()

All of these are valid and have their use cases despite looking different, as such we will allow them to all be used.