Make yarn --no-lockfile optional
See original GitHub issueWe’ve encountered an issue where we have a dependency which makes our tests fail. It’s very annoying and it would be great if --no-lockfile
could be optional, preferably set by default and you have the option to respect the lock file in a scenario if you’d like.
We use ember-try to test different builds of our ember-app. We use ember-cli-conditional-compile in order to create different builds for different websites with different features and to test the different builds we use ember-try’s different scenarios. It works great for us in most cases, but it feels like ember-try is only focusing on different scenarios where you test ember betas or other versions of ember data, etc. In those cases --no-lockfile
makes a lot of sense. But for us in order to test our different conditionally compiled scenarios we would be prefer if we could test the different compilations with the lockfile so we can make sure the tests are run with the exact same deps and the same deps as the production build will have.
A setting like --respect-lockfile
or some similiar naming could work great. I’d be happy to give it a whirl and create a PR if you find this approach reasonable?
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (5 by maintainers)
Top GitHub Comments
I think that the
nomOptions
option should default to—no-lockfile —ignore-engines
(when using yarn) and—no-shrinkwrap
(when using npm), but if the user provides a custom value (at all) we use it without modification.Currently, we always add to the options and there is (as pointed out above) no way to opt out
https://github.com/ember-cli/ember-try/blob/4f8b32aa4c54180edee984636caad3a06bf1e898/lib/dependency-manager-adapters/npm.js#L102-L120
This was fixed by https://github.com/ember-cli/ember-try/pull/409 (via
buildManagerOptions
) and is documented in the README.