Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Import rules from "eslint-plugin-ember-best-practices"

See original GitHub issue

It seems that the folks at LinkedIn started yet another ESLint plugin for Ember at https://github.com/ember-best-practices/eslint-plugin-ember-best-practices

IMHO we should focus our efforts on one plugin and eslint-plugin-ember seems to be the best fit for that.

I would like to propose to

import the rules from the other project
move this project into an independent GitHub org so that the people working on the other project can also act as maintainers here

/cc @michalsnik @trentmwillis @scalvert @rwjblue

Issue Analytics

State:
Created 6 years ago
Comments:9 (6 by maintainers)

Top GitHub Comments

2reactions

michalsnikcommented, Jul 7, 2017

Hey guys! I’m all for full cooperation, but just so you know I was already talking about this with Chad and we agreed that it’s good idea to merge some of the rules from eslint-plugin-ember-best-practices here. I even created issues in which I’m pointing which rule should be ported. You should check them out 😃 I only didn’t have enough time to work on them… But we’re going to port them at the begining of the next week 😃

And in terms of moving this repository to another organization we were also speaking about this with @rwjblue and we postponed that action point. We can talk more about this matter on EmberCamp!

0reactions

michalsnikcommented, Aug 4, 2017

@scalvert please take a look if there is anything left to add, but I think we’re good now. Some of the rules we already had, but under different names. If you’ll have any anything to add please create separate issue per each idea 😃

Top Results From Across the Web

eslint-plugin-ember-best-practices - npm

Eslint rules for linting for anti-patterns in Ember applications.. Latest version: 1.1.2, last published: 4 years ago.

eslint-plugin-ember/README.md - UNPKG

> An ESlint plugin that provides set of rules for Ember Applications based on commonly known good practices. 8. 9, ## ❗️Requirements.

Working with Rules - ESLint - Pluggable JavaScript Linter

A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.

EslintPlugin | npm.io

eslint-import-resolver-alias, eslint-plugin-html, eslint-plugin-filenames, ... ESLint plugin to follow best practices and anticipate common mistakes when ...

Add eslint-plugin-qunit to ember-cli blueprint

Summary This RFC proposes adding eslint-plugin-qunit to the blueprints ... It has over 30 rules for enforcing best testing practices and ...