question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incorrectly identifies components

See original GitHub issue

I’m not aware of how eslint-plugin-ember works internally, but I think it needs to be more intelligent in terms of how it determines what it is linting (specifically with regards to the order-in- rules).

For example:

I have a Route here: lib/styleguide/app/routes/styleguide/common/components/tag-editor.js

But, this addon determines it as Component, as you can see in the screenshot. (It says "Should be above setupController, but components don’t have setupController!)

screen shot 2018-03-11 at 19 59 45

If I rename the directory above “components” to something else, then all works as expected.

Issue Analytics

  • State:open
  • Created 6 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
rwjbluecommented, Jul 26, 2018

AFAICT right now we only use the filename to determine the type, but in this case we should have been able to see that it extends from the @ember/router/route default export (and is therefore not a component). Definitely seems like something we can/should fix…

0reactions
amk221commented, May 20, 2020

Fab thanks!!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Identify Faulty Electronic Components - Ultra Librarian
Read our guide on how to identify faulty electronic components during manufacturing and board bring-up.
Read more >
Package component upgrade list incorrectly identifies components ...
Summary Package component upgrade list incorrectly identifies components that will be upgraded, i.e., some components are listed but they will not be upgraded....
Read more >
AP Statistics: Free-Response Question 4
If the response identifies the correct test by name, but also states an incorrect formula, then component 3 is not satisfied. • If...
Read more >
Black Duck Knowledgebase matching issues help guide
Case 4: Wrong component detected (wrong single component match) – False positive; Case 5: Wrong component detected (extra component discovered) – False positive ......
Read more >
How to Identify the Main Parts of a PBL Problem - Project Pals
I thought about this problem a lot and came up with a short algorithm that trains users how to highlight components in a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found