question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

New Octane Rule: `no-actions-hash`

See original GitHub issue

Pulled from https://github.com/ember-cli/eslint-plugin-ember/issues/533 which proposes a new set of rules for Octane related best practices

Disallow using the actions hash, favoring the @action decorator or foo: action(function() {})) instead

### Good
export default Component.extend({
  foo: action(function() {}))
});

export default class MyComponent extends Component {
  @action
  foo {}
}

### Bad
export default Component.extend({
  actions: {
    ...
  }
});

export default class MyComponent extends Component {
  actions = {
    ...
  }
}

If anyone would like to implement this please comment and work away.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
patocallaghancommented, Oct 22, 2019

@bmish could you assign this issue to @laurmurclar please?

1reaction
laurmurclarcommented, Oct 21, 2019

I will happily take this one 👋

Read more comments on GitHub >

github_iconTop Results From Across the Web

eslint-plugin-ember | Yarn - Package Manager
Ember Octane ; no-actions-hash, disallow the actions hash in components, controllers, and routes, ✓ ; no-classic-classes, disallow "classic" classes in favor of ...
Read more >
eslint-plugin-ember - npm
An ESLint plugin that provides a set of rules for Ember applications based on commonly known good practices. ❗️ Requirements. ESLint >= 7 ......
Read more >
The Octet Rule: Help, Definition, and Exceptions - YouTube
The Octet Rule is a general rule that is used to describe chemical bonding and draw Lewis Structures. The rule states that Main...
Read more >
What Is The Octet Rule? - YouTube
What is the octet rule and what do we use the octet rule for? These are just a few of the questions that...
Read more >
3.2: Ions and the Octet Rule - Chemistry LibreTexts
It turns out that the Na + ion has a complete octet in its new valence shell, the n = 2 shell, which...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found