New Octane Rule: `no-component-lifecycle-hooks`

Pulled from https://github.com/ember-cli/eslint-plugin-ember/issues/533 which proposes a new set of rules for Octane related best practices

Disallow “Classic” Ember Component lifecycle hooks. Prefer using @ember/render-modifiers or custom functional modifiers.

List of Component lifecycle hooks pulled from here

// ### Good
export default class MyComponent extends Component {
  init() { ... }
  willDestroy() { ... }
}

export default Component.extend({
  init() { ... }
  willDestroy() { ... }
});

// ### Bad
export default class MyComponent extends Component {
  didDestroyElement() {}
  didInsertElement() {}
  didReceiveAttrs() {}
  didRender() {}
  didUpdate() {}
  didUpdateAttrs() {}
  willClearRender() {}
  willDestroyElement() {}
  willRender() {}
}

export default Component.extend({
  didDestroyElement() {},
  didInsertElement() {},
  didReceiveAttrs() {},
  didRender() {},
  didUpdate() {},
  didUpdateAttrs() {},
  willClearRender() {},
  willDestroyElement() {},
  willRender() {},
});

If anyone would like to implement this please comment that you’ll take it and work away.

[jbandura]

I’d like to tackle this 🙂

[Turbo87]

@jbandura yes, that was the intention. the new way of doing the same thing via modifiers works for ember components too, so IMHO we should warn about the life cycle hooks for those too