Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[require-super-in-lifecycle-hooks] False negative with Glimmer components?

See original GitHub issue

Overriding willDestroy in a Glimmer component and not calling super.willDestroy should lead to a linter warning… perhaps? Not sure if it is “mandatory” to call the super method?

Issue Analytics

State:
Created 3 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

bmishcommented, Dec 8, 2020

@boris-petrov updated rule to catch willDestroy in both glimmer and non-glimmer components.

1reaction

bmishcommented, Dec 8, 2020

Actually, it looks like classic components do have a willDestroy too: https://api.emberjs.com/ember/3.22/classes/Component/methods/willDestroy?anchor=willDestroy

Top Results From Across the Web

Glimmer Components - Octane Upgrade Guide - Ember Guides

For this section, we'll be focusing on the differences between the new style, known as Glimmer components, and classic components, and how to...

Pass attributes to glimmer components when using ... - GitHub

This looks like a missing piece to achieve parity between "ember and glimmer" components when using the (component) helper. With angle brackets and...

Dynamically determine existence of template only Ember ...

The component doesn't seem to be registered in that case. Does anyone know a solution that would work for template-only glimmer components too?...

Simpler and more powerful components in Ember Octane with ...

Ricardo Mendes explains how Glimmer components provide a simpler and clearer, yet more powerful, component layer for Ember Octane ...

Unit-testing Glimmer Components - Tim G. Thomas

Most of my Ember projects use a large number of component unit tests, so this was a bummer to discover: I'd have to...