Rule no-get-properties not work?

It seems like no-get-properties rule not work. I’ve setup error state on this rule in .eslintrc file, but still linter always pass through without error even though the getProperties function is used incorrectly. I have the same settings with no-get rule, but I’m getting error correctly so I guess must be something wrong with this rule.

[bmish]

@bobisjan the rule is currently limited to “destructuring assignments” that look like the following example because it’s trivial to simply remove the getProperties call from them.

const { abc, def } = this.getProperties('abc', 'def'); // Before
const { abc, def } = this; // After

Other usages would need a slightly more complex replacement to maintain the same behavior:

let data = this.getProperties('bar', 'foo', ...) // Before
let data = { this.bar, this.foo, ... } // After

If there’s interest in catching this more general usage, I would be open to updating the lint rule to do so.

[bobisjan]

For our case the node.id.type is Identifier, which results to skip linting by this condition https://github.com/ember-cli/eslint-plugin-ember/blob/master/lib/rules/no-get-properties.js#L24

export default Component.extend({
  foo() {
    let data = this.getProperties('bar');
  }
});

Node {
  type: 'Identifier',
  start: 591,
  end: 594,
...