How use contentFor in engines

So, I have a engine with lazyLoading: false inside a fresh ember app. My engine have addons and one of them have the code below:

# index.js
/* eslint-env node */
'use strict';

module.exports = {
  name: 'ember-cli-neutral',

  contentFor(type, config) {
    if (type === 'head') {
      if (config.googleFonts) {
        let families = config.googleFonts.join('|');

        return '<link href="https://fonts.googleapis.com/css?family=' + families + '" rel="stylesheet">'; // eslint-disable-line
      }
    }
  }
};

# environment.js
/* eslint-env node */
'use strict';

module.exports = () => {
  const ENV = {
    googleFonts: [
      'Roboto:400,500'
    ]
  };

  return ENV;
};

If I run engine separately the link of google fonts works perfectly, but if I run inside the fresh ember app not.

Perhaps a feature for future or it’s outside the scope of this project?

[trentmwillis]

it seems somewhat odd to allow other addons to mutate the main apps index.html (considering that engines are essentially an isolation primitive)

Agreed. However, it also seems that we would want Engines to be able to use addons that have contentFor hooks. I’m not sure what the best solution here, but I lean towards enabling contentFor for an Engine’s addons for consistency, as I believe it is what users would expect.

[ascudder]

I wanted to add my support for allowing engines to use contentFor as well. One of our engines needs to pull in a 3rd party dependency by adding to the index.hrml file. My first thought was that “engines are just a kind of addon,” so I expected it would work, but was surprised to find out that it doesn’t work and to find this issue.