Including vendor dependencies in lazyloaded engines not working.

With a clean ember-cli 2.12 and ember-engines 0.5.0 addon setting lazyloaded to true throws an error when trying to find a vendor file I have added to the vendorTree.

Running ember server on this repo will reproduce the issue. Changing the lazyloaded to false you will be able to build the app.

I would expect highlightjs and the shim be added to engines-vendor.js file.

The vendorTree can be found here

index.js file

module.exports = EngineAddon.extend({
  name: 'vendor-lazy-engine',
  lazyLoading: true,

  included: function(app) {
    this._super.included(app);

    this.import('vendor/highlight.pack.js', {
      exports: {
        'highlight.js': [
          'default',
          'highlight',
          'highlightAuto',
          'highlightBlock'
        ]
      }
    });

    this.import('vendor/shims/highlightjs.js');
  },

  treeForVendor() {
    var tree = this._super.treeForVendor.apply(this, arguments);

   let hljsPath = path.parse(require.resolve('highlightjs'));
    
    let highlightTree = new Funnel(hljsPath.dir, {
      files: [hljsPath.base],
    });

    let vendorTree = MergeTrees([tree, highlightTree]);
    let debuggedTrees = debug(vendorTree, { name: 'vendorTree' });

    return debuggedTrees
  }
});

https://github.com/kiwiupover/vendor-lazy-engine

[xm]

@SanthoshRaju91 according to https://ember-cli.com/extending/

For live reload when developing an addon use the isDevelopingAddon hook:

// addon index.js
isDevelopingAddon() {
  return true;
}

[geekygrappler]

@Turbo87 and I recently overcame this by using an in-repo-addon. For example we generated an in-repo addon: $ ember g in-repo-addon tl-mailcheck

Then added that addon as a dependency of the engine in it’s package.json:

  "ember-addon": {
    "paths": [
      "../tl-mailcheck"
    ]
  }

In the addons index.js:

const commonjs = require('rollup-plugin-commonjs');
const nodeResolve = require('rollup-plugin-node-resolve');
const Rollup = require('broccoli-rollup');


module.exports = {
  name: 'tl-mailcheck',

  isDevelopingAddon() {
    return true;
  },

  treeForAddon() {
    return new Rollup(`${__dirname}/lib`, {
      rollup: {
        entry: 'index.js',
        dest: 'tl-mailcheck.js',
        format: 'amd',
        moduleId: 'mailcheck',
        plugins: [
          nodeResolve(),
          commonjs(),
        ],
      },
    });
  },
};

Note mailcheck is CommonJS and we want amd, so we’re using rollup to convert it… And our entry file lib/index.js just has import and export.

import mailcheck from 'mailcheck';

export default mailcheck;

Mailcheck dependency remains in the package.json for the host app, but appears only in engine-vendor.js

Also, ember g in-reop-addon will add that addon as a dependency of your main host app, so make sure to remove it from the ember-addon part of your main package.json (or you’ll get the dep in vendor.js as well).