Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fastboot does not respect `rootElement`

See original GitHub issue

If rootElement is defined in an application, both the fastboot HTML and the Ember DOM are rendered.

Issue Analytics

State:
Created 7 years ago
Comments:11 (8 by maintainers)

Top GitHub Comments

1reaction

markmhxcommented, Mar 9, 2018

I’m strangely seeing the double render suddenly in the opposite case, where the rootElement is not set…and if I set it to an arbitrary value, the double rendering stops 😶

I noticed in my package.lock that ember-cli-fastboot had upgraded automatically during my last npm install from 1.1.1 to 1.1.3 and fastboot itself correspondingly from 1.1.2 to 1.1.3 since my package.json had ember-cli-fastboot set to ^1.1.1.

"ember-cli-fastboot": {
-      "version": "1.1.1",
-      "resolved": "https://registry.npmjs.org/ember-cli-fastboot/-/ember-cli-fastboot-1.1.1.tgz",
-      "integrity": "sha512-hctBX1MQYTDjYF2ISR6qZIT+fY4mmJFwCskNM/ruHTmN0XKgSSvRijRfF9y/VgpDux77iEDMNT9C5ZIzhSFEoA==",
+      "version": "1.1.3",
+      "resolved": "https://registry.npmjs.org/ember-cli-fastboot/-/ember-cli-fastboot-1.1.3.tgz",
+      "integrity": "sha512-9TuF4O/rTF82LdefWvNm8mLiLP1RpAAuufrC6EnTiHmhdyL0Ni4kb7uhkYd356zF+n1F2Cj6fNQu/JfwMbjG1g==",
       "dev": true,
       "requires": {
         "broccoli-concat": "3.2.2",
         "broccoli-funnel": "2.0.1",
         "broccoli-merge-trees": "2.0.0",
         "broccoli-plugin": "1.3.0",
-        "chalk": "2.3.0",
+        "chalk": "2.3.2",
         "ember-cli-babel": "6.11.0",
         "ember-cli-lodash-subset": "2.0.1",
+        "ember-cli-preprocess-registry": "3.1.1",
         "ember-cli-version-checker": "2.1.0",
-        "fastboot": "1.1.2",
+        "fastboot": "1.1.3",

Changing my package.json for ember-cli-fastboot to stay at 1.1.1 and reinstalling dependencies also resolved the double rendering without having to set an arbitrary rootElement, so the bug seems to have been produced during one of the above version changes.

0reactions

snewcomercommented, Jul 31, 2018

Is this fixed as of this commit since it clears out everything in the <body> tag? https://github.com/ember-fastboot/ember-cli-fastboot/pull/569/files