In fastboot sandbox the `URL` global object is not WHATWG URL

Since Node.js 10 the URL is available as global variable, and it is WHATWG URL API - “Browser-compatible URL class, implemented by following the WHATWG URL Standard”. But under fastboot I can not use new URL(...), because sandbox globals assigns URL to require('url'). https://github.com/ember-fastboot/ember-cli-fastboot/blob/9e0b053cced1189ffeaafa827a386a8f82a1b788/packages/fastboot/src/sandbox.js#L17-L26

It’s very confusing because:

1. it differs from nodejs, where globalThis.URL === require('url').URL
2. I can’t write code new URL(...) in app that will be valid for both environments - browser and fastboot. Instead, I have to write like this IS_FASTBOOT ? new URL.URL(...) : new URL(...) or use buildSandboxGlobals to assign URL to require('url').URL instead of default require('url').

In my opinion, the URL global variable in fastboot should be the same as for Node.js:

-   let URL = require('url');
+   let { URL } = require('url');
    let globals = this.globals;

    let sandbox = Object.assign(
      {
        sourceMapSupport,
        console,
        setTimeout,
        clearTimeout,
        URL,

Also, it make sense because support of Node < 10 has been dropped here (#695).

[simonihmig]

Just tripped over this. In an addon, where I cannot influence the sandbox globals, I had to revert to this ugly check:

const URLConstructor: typeof URL =
        typeof URL === 'function' ? URL : (URL as { URL: typeof URL }).URL;

Would be nice to get this fixed in a stable v3!?

Maybe pass require(‘url’).URL to sandbox, and define a a getter for URL.URL with deprecation warning?

If we want to keep compatibility with the url module and at the same time compatibility with the WHATWG API, that would mean not only exposing URL.URL, but also all the other module exports, right? This is how the export currently looks like when logged:

{
  Url: [Function: Url],
  parse: [Function: urlParse],
  resolve: [Function: urlResolve],
  resolveObject: [Function: urlResolveObject],
  format: [Function: urlFormat],
  URL: [class URL],
  URLSearchParams: [class URLSearchParams],
  domainToASCII: [Function: domainToASCII],
  domainToUnicode: [Function: domainToUnicode],
  pathToFileURL: [Function: pathToFileURL],
  fileURLToPath: [Function: fileURLToPath]
}

Doable, but also kinda ugly.

[ryanflowers]

Bumping my version of ember-source to 3.22 solved this issue for me. The code throwing the exception is not gone, no other changes needed.