question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

queryManager breaks IE11

See original GitHub issue

Currently, a project of mine breaks in IE11 if I’m using the queryManager macro (as a decorator as well as a normal CP):

Object doesn't support property or method 'Symbol(Symbol.iterator)_9.z506oiom8fn'

The babel config should not be a problem since other decorators from ember-concurrency-decorators and built in ember decorators work fine…

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:2
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
vsergiu93commented, Oct 21, 2019

I have just stumbled on this issue, after spending 5+ hours on this I ended up forking the repository and make my app use the new repo, in this way I can debug the code easier.

This what the error looks like in IE 11: image

It seems the problem originates from this function: https://github.com/ember-graphql/ember-apollo-client/blob/0c3d847d6c8e2b1050b901c8e7df901bb20f4771/addon/-private/apollo/query-manager.js#L27-L46

More exactly on this line: https://github.com/ember-graphql/ember-apollo-client/blob/0c3d847d6c8e2b1050b901c8e7df901bb20f4771/addon/-private/apollo/query-manager.js#L40 where it’s calling isElementDescriptor with arguments as a parameter.

I went to MDN to refresh my memory on arguments and I found this two notes:

  • If you're writing ES6 compatible code, then rest parameters should be preferred.

  • “Array-like” means that arguments has a length property and properties indexed from zero, but it doesn't have Array's built-in methods like forEach() and map(). See §Description for details.

Now after reading those two notes I wend back to IE 11 and had a closer look at the generated code and decided to use the rest parameter approach for queryManager and the app started working.

This is how the queryManager function looks after refactoring https://github.com/vsergiu93/ember-apollo-client/blob/6d1f5a45dd3128603d2cdd6b86adc0bb593b7b74/addon/-private/apollo/query-manager.js#L27-L48.

I’m not sure where to go from here should I submit a PR is this a viable solution?

0reactions
josemarluedkecommented, Oct 22, 2019

This should now be fixed in v2.0.0-beta.7.

Thank you @vsergiu93 and @anehx.

Read more comments on GitHub >

github_iconTop Results From Across the Web

IE11 is not responding due to a long-running script. Query ...
IE11 is not responding due to a long-running script. Query Manager Track Wise. Current version of internet explorer on computer.
Read more >
"Out of stack space" error #3043 - apollographql/apollo-client
When we comment out our graphql queries, our application works fine on IE11. The weird thing is this error only occurs when Google...
Read more >
ember-apollo-client - Bountysource
Currently, a project of mine breaks in IE11 if I'm using the queryManager macro (as a decorator as well as a normal CP):....
Read more >
Oracle JDeveloper 12.2.1.4.0 - Release Notes
This is a subset of the total number of internal, unpublished bugs fixed. Number, Subject. 29584952, IE11: FREEZE/WRAP BUTTONS GET ENABLED AFTER DETACH/REATTACH ......
Read more >
Using Feature Detection to Write CSS with Cross-Browser ...
... recently sent me a link to the phenomenal Feature Query Manager ... However if we were to test it in Internet Explorer...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found