Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

1-0 branch, Infinity-loader's `destroyOnInfinity` does not seem to work

See original GitHub issue

Hi! I am not positive, but the destroyOnInfinity property available on the infinity-loader no longer seems to work.

I can confirm that this line is called. But the element stays in the DOM… nothing happens. If you add the destroyOnInfinity to the dummy app, the element never goes away. I can write a failing test for it if you need.

Since everyone is pushing on a 1-0 release, it might make sense to instead toggle the isVisisble attribute on the component? I am not sure that components are supposed to be destroying themselves…

Easy workaround, Add this to your CSS:

.infinity-loader.reached-infinity {
  display: none !important;
}

Issue Analytics

State:
Created 6 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

Duder-onomycommented, Dec 19, 2017

Totally. I will PR into the 1-0 branch and add some notes to the readme for upgrading.

0reactions

snewcomercommented, Dec 19, 2017

@Duder-onomy ah that might be even better! Awesome idea 👍 Could add to #242 but still waiting for an upstream PR into ember-in-viewport 😦 . It might be sitting there for a while, so maybe you/I could do a PR into the 1-0 branch instead.