infinity-loader needs to unhide on model change
See original GitHub issueThe infinity-loader
will stop functioning permanently on infinity when hideOnInfinity=true
. However, when the model changes and has new content because of a change in filters (similar to #331), the infinity-loader
should unhide itself because we’ve no longer reached infinity.
I think a property on the model should be watched inside the infinity-loader
helper. Not sure what that property should be, but probably something like isLoaded
, isDoneLoading
, canLoadMore
or something that resets when the model changes.
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (4 by maintainers)
Top Results From Across the Web
Infinity Loader
Infinity Loader. The only GSC Compiler tailored for the IW Engine. Supported across Xbox and PC. Powered by Infinity Loader.
Read more >Windows Update breaks infinity loader - Beamdog Forums
I have just installed an update to Windows 10. My shortcut to Infinity Loader (Gog installation) disappeared.
Read more >How To Setup Infinity Loader [Tutorial] - YouTube
How To Setup Infinity Loader [Tutorial]. 8.4K views 3 years ago. Moxah - Modding, Trolling, Glitches & Tutorials. Moxah - Modding, Trolling ...
Read more >HOW TO PORT ANY INFINITY LOADER PROJECT ... - YouTube
New EASIER tutorial: https://www.youtube.com/watch?v=7MepTbdJlmUDiscord: https://gsc.dev/s/discord.
Read more >How To Fix Cumulative Layout Shift (CLS) Issues
Basically, if you have content that you know is going to cause shifts, then one solution to avoid the shifts is to not...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Thank you for the issue! What we ultimately need to do is observe
reachedInfinity
and resetisVisible
when it changes tofalse
. #413One day, we can move away from observers, but for now I think the referenced PR fixes it.
Does this mean we can use the one-liner again without wrapping it in
{{#unless model.reachedInfinity}}
? That would be great!