Add support for `hourCycle` date/time format option

• I am on the latest ember-intl version
• I have searched the issues of this repo and believe that this is not a duplicate

Environment

• Ember Version: 3.13.2
• Ember CLI Version: 3.16.0
• Ember Intl Version: 4.3.2
• Browser(s): Chrome 81.0.4044.122
• Node Version: 8.12.0

Steps to Reproduce

This is not a bug but a feature request. It’d be great if this addon supported the overriding of the hourCycle property for date and time formatting LINK to docs.

To be clarified

• Is this change desired?
• Patch for 4.x branch
• Patch for master branch?

[achambers]

👋 Hi maintainers. Thanks for a great addon.

We have come across a scenario where we need the ability to set the hourCycle property when formatting times. It’s a simple change to this codebase but wanted to document it as an issue to find out what the etiquette is for contributing this sort of change.

Firstly, is this something you’re open to exposing to users and adding to this addon?

If so, I have a PR ready to go (#1261), including updates to tests and docs.

I see the code of the format-date file has changed between the 4.x branch and master. What is the workflow here in terms of shipping the change to the 4.x series as well as master? If we go ahead with this, shall I raise two PR’s, one against the 4.x branch and one against master?

I’ll create the PR I have against 4.x and link it to this issue for now, as a means of facilitating the discussion.

[jasonmit]

Just started to get back to it now and see it’s done. Thanks man. Sorry for not getting to it sooner.

Not a problem, I just wanted to get it out to cut 5.0.0. Thanks for landing it in the first place!