ember-octane compatibility

I tried to play with ember-octane preview and I got into troubles with some internal dependencies of this project. I did not even finish the quickstart guide. Not sure whether this is octane or ember-cli-addon-docs issue.

The way to reproduce this:

git clone https://gitlab.com/michal.bryxi/ember-safe-button.git -b ember-app-scheduler-build-bug
cd ember-safe-button
yarn
ember s

Open: http://localhost:4200 and see that there is following error in the console:

loader.js:247 Uncaught (in promise) Error: Could not find module `ember-app-scheduler` imported from `ember-router-scroll/index`
    at missingModule (loader.js:247)
    at findModule (loader.js:258)
    at Module.findDeps (loader.js:168)
    at findModule (loader.js:262)
    at Module.findDeps (loader.js:168)
    at findModule (loader.js:262)
    at Module.findDeps (loader.js:168)
    at findModule (loader.js:262)
    at requireModule (loader.js:24)
    at Class._extractDefaultExport (index.js:413)
...

[NullVoxPopuli]

if anyone comes across this issue and has the motivation to fix octane support, the edition utils package have a way of detecting edition:

https://github.com/emberjs/ember-edition-utils#detecting-edition

const { has } = require('@ember/edition-utils');

if (has('octane', this.project.root)) {
  // do octane stuff
} else {
  // do classic mode stuff
}

[nadnoslen]

Hey @MichalBryxi,

I have been running into another problem altogether (a computed property key must be a string ... undefined undefined) when I work through the Quick Start for an Octane addon.

I notice you haven’t really followed (and you say finished) the quick start though. Your application.hbs & index.hbs should be populated. I wonder if that is hindering you? I assume if you keep going until it tells you to start your server you’ll get a different error?

Anyway, I’m working on this myself right now and if I see anything helpful I’ll pass it on.

(and I can confirm what you’re seeing after cloning your repo)