Question -- how combine reducers in ember-redux?

I saw examples of combining reducers over in the redux.js.org docs. I was wondering how to go about this in Ember redux? For this example, I have a settings and a users reducer, that will manage those pieces of the state respectively, so the store’s state shape should be

{
  settings: // settings data,
  users: // users data
}

I tried bringing in redux and doing this with combineReducers, but I got an error – here are my reducers:

// app/reducers/settings.js
const settings = (state, action) => {
  // reducer code here
};

export default {
  settings
}


// app/reducers/users.js
import { combineReducers } from 'redux';
import settings from './settings';
const users = (state, action) => {
  // reducer code here
};

export default combineReducers({
  settings,
  users
})

It worked if I switched the exports for the two reducers to be as follows:

// settings.js
export default settings

// users.js
export default {
  settings,
  users
}

But I wasn’t sure if that does what it needs to. The redux docs show a longhand combineReducers equivalent like this:

// users.js
function rootReducer(state = {}, action) {
  return {
    settings: settings(state.settings, action),
    users: users(state.users, action)
  };
}

export default rootReducer

But that didn’t work for me either.

What is the ember-redux way to combine reducers together to compose a state tree?

[toranb]

@skitterm this is now up in the v2.5.0 release on npm

Let me know if anyone has issues/ or further questions about combineReducers specifically

The store extensibility discussion will continue over in PR #121 for those interested

[skitterm]

@skitterm if you npm install the branch in PR #119 does it work as you expect allowing you to leverage combineReducers?

Yep, it works great.