Ambiguous path is not allowed in tagged template

When running with the new no-implicit-this rule, my test files are being picked up, for example:

test('something', async function(assert) {
  this.set('thing', {
    id: 123
  });

  await render(hbs`{{my-thing thing=thing}}`);
});

Ambiguous path 'thing' is not allowed. Use '@thing'

But the test fails if I change it to that.

It’s only complaining about a small selection of tests, despite there being many other similar tests (I’m not sure what it special about the few).

[rwjblue]

Hmm, there are a few different pieces here I think.

• to have the inline test templates checked I think you must be using eslint-plugin-hbs. eslint-plugin-hbs is hard coded to use the 0.8.x version of ember-template-lint (see here) which makes interop quite a bit trickier. I created https://github.com/psbanka/eslint-plugin-hbs/issues/25 to chat through that.
• I don’t think that (in the snippet you gave) you should swap to @thing, it should instead be this.thing. Do the tests pass if you do it that way?
• I am not sure why only some tests have the issue, can you test by copying one of the ones that work into a file of one that doesn’t, and see if it still complains?

Thanks for testing and reporting!

[amk221]

Ok thanks, I’ll track that issue you linked to!

What about the other point I mentioned? Would I be right in thinking, that to create a failing test I should add:

{{helper}}

Here: https://github.com/ember-template-lint/ember-template-lint/blob/master/test/unit/rules/lint-no-implicit-this-test.js#L23 ?