Issues with todos when upgrading from v3.4.2 to v4.3.0
See original GitHub issueI’m having trouble upgrading ember-template-lint from v3.4.2
to v4.3.0
. The steps I have taken are:
- Upgrade from
^3.4.2
to^4.3.0
. - Change my
.template-lintrc.js#extends
property to['recommended']
.
At this point I run yarn lint
and it says: “Found .lint-todo directory. Please run npx @lint-todo/migrator
to convert to the new todo file format”. So I run that command and it very quickly flashes a message that I need to use a --remove-v1
flag, so I try that and it deletes all the existing todos. If I run yarn lint
now it completes and shows me all the errors that were previously todos. So next I run npx ember-template-lint . --update-todo
to recreate my todos in the new format, which works. I now have a .lint-todo
file and when I run yarn lint
it passes. However, If I switch to another branch in git, then switch back to this branch, and then run yarn lint
again (after install) it fails with all the todos again, even though the .lint-todo
file is there. This also happens on our CI servers.
Is there some upgrade step or configuration that I’m missing? Thanks!
Issue Analytics
- State:
- Created a year ago
- Comments:5 (4 by maintainers)
Top GitHub Comments
@adc-mhaugen thanks so much for taking the time to create this repro. This’ll help immensely. I’ll see if I can figure out what’s happening today and will report back.
I’m going to close this, but feel free to open it again if I’m incorrect in the behavior.