question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

no-invalid-interactive cannot be disabled

See original GitHub issue

When updating to 1.6.2, I run into the following problem:

I have this template:

{{! template-lint-disable no-inline-styles }}

{{! We add a transparent circle underneath the actual circle to make it easier clickable }}
<g data-test-chart-line-circle-container>
  <circle
    r="0.8rem"
    cx={{@x}}
    cy={{@y}}
    class="chart-line-circle__padding"
    data-test-chart-line-circle-padding
    {{on "click" this.clickCircle}}
    {{on "mouseenter" this.focusCircle}}
    {{on "mouseleave" this.blurCircle}}
  />

  <circle
    r="0.15rem"
    cx={{@x}}
    cy={{@y}}
    class="chart-line-circle {{if this.isFocused "chart-line-circle--is-focused"}}"
    style={{this.svgPathStyle}}
    data-test-chart-line-circle

    ...attributes
  />
</g>

Which now (correctly) raises

error Interaction added to non-interactive element no-invalid-interactive

If I try to disable this:

{{! template-lint-disable no-inline-styles no-invalid-interactive }}
...

I get:

-:-  error  Cannot read property 'length' of undefined  undefined

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
rwjbluecommented, Nov 4, 2019

I think it’s good that it caught this- you’d need some kind of role on the interactive element.

Ya, but that’s not exactly what this issue is tracking. A quick recap here is:

  • We landing a “breaking bugfix” in no-invalid-interactive (https://github.com/ember-template-lint/ember-template-lint/pull/864), to ensure that it checks for {{on usage. This is definitely a bugfix (and as such not a "SemVer violation), but it still means @mydea’s app can’t pass linting.
  • There is some sort of failure when attempting to disable that particular rule with the inline comment.

tldr; Disabling with the inline comment should never cause this kind of fatal failure, and the fact that it does means we have a logic error.

0reactions
mydeacommented, Dec 13, 2019

I just tried again on 1.10, and it works now! Not sure if/what has changed though 🤔 Anyhow, thanks for looking into it!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to fix warning "interaction added to non ... - Stack Overflow
The solution here depends on what the action should do. Refactoring an action that triggers a transition. Since this action takes the user ......
Read more >
Microsoft Dynamics CRM Forum - Non-interactive user
I believe a non-interactive user would be a user whose enabled in CRM but do not consume any licenses. These user would not...
Read more >
Duo Authentication Windows Logon RDP: FAQ | Duo Security
Double-click the Interactive logon: Do not display last user name setting. Select Enabled and click OK. Close the Local Group Policy Editor ...
Read more >
ANDI - Alerts - SSA
Why is this an accessibility concern? If this table has no cells, is it really a data table? Users with a vision disability...
Read more >
Websites look wrong or appear differently than they should
Check that JavaScript is not blocked ... You should check whether you have an extension (such as NoScript) or Internet security program (such...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found