no-unnecessary-concat questionable recommendations?

In testing out v1.0.0 of ember-template-lint, we noticed the no-unnecessary-contact rule making recommendations like changing href="{{foo}}" to href={{foo}}. We’re not entirely sure this is correct and wanted to bring it up for reevaluation to see if this rule needs refinement or if we’re misunderstanding what is the recommended best practice here.

cc: @rwjblue

[rwjblue]

so as long as we do not introduce the opposite rule as a default or make “folks should be using quoted attributes” a general rule

We do already have a rule in the recommended set for preventing this:

<div data-whatever=something></div>

Its primary point is to require either quotes or mustaches (this prevents the <FooBar @blah=derp /> style of issue I mentioned in those linked issues above). It does not take a side RE: which one to use though.

no-quoteless-attributes

[Turbo87]

to recap:

• I think that formatting without quotes is better
• you think that formatting with quotes is better
• the templates are slightly smaller

ultimately it comes down to whether we consider this to be primarily a formatting/code style thing, or if this prevents actual issues. I tend to agree by now that this might be the former, so as long as we do not introduce the opposite rule as a default or make “folks should be using quoted attributes” a general rule, I guess I’m fine with removing it from the default set.