question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rule proposal: no-action-on-submit-button

See original GitHub issue
{{! bad }}
<button {{action "cancel"}}>cancel</button>

{{! good }}
<button type="button" {{action "cancel"}}>cancel</button>

because there should be a submit action on <form> instead, to catch any submit event. and if a <button> is not a submit button, there should be type="button"

Issue Analytics

  • State:open
  • Created 7 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
Turbo87commented, Dec 1, 2019
1reaction
rwjbluecommented, May 13, 2016

I think there is a tad more nuance here. As I don’t think that <button {{action 'foo'}}></button> itself is bad, it is only bad when contained within a <form>, right?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Shareholder Proposal No-Action Responses Issued Under ...
Under Rule 14a-8(j), a company seeking to exclude a shareholder proposal must file its reasons with the Commission no later than 80 calendar ......
Read more >
Shareholder Proposal No-Action Requests in the 2021 Proxy ...
As calendar year-end companies received shareholder proposals for their 2021 annual meetings, they faced a variety of uncertainties and ...
Read more >
SEC Should Truly Take 'No Action' - Jones Day
has announced that it may no longer review no-action letter requests relating to shareholder proposals submitted to companies under Rule 14a-8.
Read more >
Companies Take Action Via No-Action Letter | Article
The rule requires the company to include the proposal unless the shareholder has not complied with the rule's procedural requirements or the proposal...
Read more >
no-action - ember-template-lint - GitHub
✓ The extends: 'recommended' property in a configuration file enables this rule. What's wrong with {{action}} ? ... 2.) But also element modifiers...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found