[Rule Request] Element Attribute Order

Not exactly sure how to call this rule. Pretty much what I want is a rule that would throw on incorrect order inside of Element/Component invocation.

For example: Take this component:

<MyComp @name="test" data-test="123" @doSomething={{action "gogogo"}} class="flex" />

There is no order to the attributes/modifiers etc

I think there should be an order such that class is first, then data-test then props then actions Any thoughts?

[rwjblue]

I think I’d prefer:

• arguments
• attributes
• element modifiers
• ...attributes
• block params

To move forward here I think we need something like the following steps:

• create a new rule (component-invocation-order, element-space-order, some other name?)
• in the rule, implement the ElementNode visitor that ensures the ordering is correct
• group node.attributes into “arguments” and “attributes” based on a leading @
• compare the loc information of each entry in the three categories (arguments, attributes, and modifiers) to see if they match our expected ordering
  • confirming that no attributes (non-@ starting entries in node.attributes) are before the arguments (the @ leading names in node.attributes)
  • confirming that no modifiers are before either attributes or arguments
  • etc…

How does that sound?

[bmish]

Available in v4.18.0, thanks @rob-long!