separate rule violations with the same line, column and rule name cannot both create a TODO

Example failure (1 TODO created, 1 violation not converted to TODO)

  2:2  todo  <div> has a role of tab, it cannot have semantic descendants like <h5>  require-presentational-children
  2:2  error  <div> has a role of tab, it cannot have semantic descendants like <a>  require-presentational-children

note the offending h5 and a elements are not on line 2 in the associated file, that is merely where the div opens.

Offending content (sorry for the 😱 code)

<div class="card analytics-runner-card no-radius">
  <div
  class="card-header analytics-runner-card-header no-radius"
  role="tab"
  id="columnsAria"
>
  <h5 class="mb-0">
    <a
      data-toggle="collapse"
      class="nav-link"
      data-parent="#accordion"
      href="#columns"
      aria-expanded="false"
      aria-controls="columns"
    >
      {{t "analytics.column_order"}}
    </a>
  </h5>
</div>
</div>

[scalvert]

This does seem like we’re incorrectly reporting the line/column for the violation. If the same rule is flagged with the same line/column, it’s considered the same.

I suspect this is a bug in the rule, not todos.

[rwjblue]

Hmmm. Seems to me like the issue is with which node we are reporting as incorrect (RE: line + col). We should either report only a single error for this case (which would make todo’s work fine), or report individual errors but using the specific invalid child as the line+col instead of always using the parent’s node.