question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[todos] Add days to warn/error configuration in lint todo config

See original GitHub issue

Currently there’s no serialized source of truth for configurations for days to warn/error. When creating todos, those days are configured in an ad hoc manner. We should extend our current configuration to include specific configurations for days to warn/error, per rule.

Example:

{
  "lintTodo": {
    "decayDays": {
      "warn": 5,
      "error": 10
    },
    "decayDaysByRule": {
      "link-href-attributes": { warn: 30, error: 90 },
      ...
    } 
  }
}

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
scalvertcommented, May 17, 2021

Proposed changes:

  1. Support both configuration styles:

    • package.json configuration (supports simple config where you only supply defaultDecayDays
    • .lint-todorc.js configuration (supports larger, more complicated configuration)
  2. Expand configuration as per original suggestion:

    {
      "lintTodo": {
        "decayDays": { "warn": 5, "error": 10 },
        "decayDaysByRule" : {
          "link-href-attributes": { warn: 30, error: 90 },
          ...
        }
      }
    }
    
1reaction
rwjbluecommented, Apr 12, 2021

We originally chose to use package.json because the same settings would be read by multiple tools (not just ember-template-lint). I do agree that we might want to have a separate config file, but it can’t (directly) be .template-lintrc.js.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How To Todo In Ember Template Lint
All rules (generic setting). It's possible that you don't care what the error is; all todos should have 15 days before they turn...
Read more >
ember-template-lint | Yarn - Package Manager
ember-template-lint is a library that will lint your handlebars template and return error results. For example, if the rule no-bare-strings is enabled, ...
Read more >
Configuring ESLint - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
TODOCheck: A Static Code Analyser for Annotated TODO ...
First, you need to configure todocheck 's integration with your issue tracker. This is done by creating a .todocheck.yaml file in the root...
Read more >
https://raw.githubusercontent.com/ember-template-l...
... Fixes issue where lint-todos add blank lines in .lint-todo storage file ... feat(todos): Adds support for configuring todo decay days by rule ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found