Update recommended rule set

Primary objectives:

• Remove “style” related rules from the recommended set
• Add Octane related rules to recommended set
• Update list of A11Y rules in recommended set

Rule Changes

Add

• no-abstract-roles
• no-action
• no-curly-component-invocation
• no-extra-mut-helper-argument
• no-implicit-this
• no-obsolete-elements
• no-positive-tabindex
• no-unnecessary-component-helper
• require-iframe-title
• require-valid-alt-text

Remove

• block-indentation
• img-alt-attributes
• linebreak-style
• no-unnecessary-concat
• quotes
• self-closing-void-elements

Change Default Config

• link-rel-noopener -> strict config

[rwjblue]

My understanding is that the no-action-modifiers and no-element-event-actions rules are exact opposites of each other. So why are they both enabled?

Don’t use action in templates at all, use {{on}} 😸. Specifically, the next major (when these recommended sets can be updated) will be primarily targeted at octane users and in that world we expect folks to use {{on}} exclusively (over either form of action and over the Ember.Component event methods like click).

Are the style rules (block-indentation, linebreak-style, quotes) removed because prettier for handlebars will take the place of these?

Yes, this is precisely why they are removed. Just like with eslint’s recommendations, our “recommended” set should only be about “correctness” and not “stylistic opinion”.

I absolutely still expect folks to bring these rules themselves or use prettier to enforce the style.

img-alt-attributes is deprecated and replaced by require-valid-alt-text.

Confirm.

I assume no-unnecessary-concat is removed because of the discussion in #604.

Confirm.

I assume self-closing-void-elements is removed because of the discussion in #691.

Confirm.

[rwjblue]

Closed by #899