Use of reopen clashes with an action of the same name

Describe the bug In our app we have a component that displays a Task (an ED model) Tasks can completed, and reopened.

In the component there is an action called reopen

@action
reopen() {
  // make PUT request...
}

There is a click handler to reopen a task.

I noticed that a PUT request was being made to reopen the task, even though I hadn’t clicked anything.

After a bit of digging, it seems that there is some confusion between my reopen action, and Ember’s Classic Object method reopen, and Ember inspectors usage of it.

To Reproduce Unsure, I tried to make a demo repo, but was unsuccessful.

Expected behavior My reopen action should not be called. (I can fix this, by renaming it reopenTask, or uninstalling the Ember inspector)

Screenshots

Environment Ember 3.16.1, Chrome 81

Additional context N/A

[amk221]

That’s fine, thanks.

I guess originally I thought @action would be doing something like the old actions hash under the hood, thereby keeping is separate from the actual reopen. But, now I understand more about it. Makes sense, I’ll just rename it.

Thanks

[rwwagner90]

We’ve hit some issues before where people are trying to use a built in Ember method name as their own, and I believe our stance has been to recommend against using those names in your app. Can you confirm @chancancode @rwjblue?