[Bug] Default queryParams are not getting pruned

🐞 Describe the Bug

Transitioning to from a parent route with queryParams to a child route with queryParams using the router service, fails to prune default queryParams leaving the URL in an undesired state

🔬 Minimal Reproduction

https://github.com/lvegerano/ember-qp-prune-fail

😕 Actual Behavior

Having the following routes:

• main
  • route-a

main has a queryParams

queryParams = [
    {
      labelIds: {
        type: 'array',
        as: 'l',
      },
    },
  ];

routing to main.route-a using the router service adds the serialized array brackets to route-a URL http://localhost:4200/main/route-a?l=%5B%5D

🤔 Expected Behavior

The URL does not contain the default value of the queryParam http://localhost:4200/main/route-a

🌍 Environment

• Ember: - 3.25.3
• Node.js/npm: - 3.25.3
• OS: - Mac/Windows WSL
• Browser: - Chrome 89

[lvegerano]

@bertdeblock It also happens in 3.14. Reading the RFC you are correct. Its terrible DX. How is it ok to have different behaviors when transitioning to a route? 🤯

[lvegerano]

Thanks for your input @bertdeblock. The RFC certainly makes it sounds as if this is the intended behavior 🤷🏾‍♂️ .