disabledClass of link-to component might not work, depending on attributes order

link-to component has not documented property disabledClass which is supposed to change class of disabled link. I see that it’s marked as private but sometimes this feature is needed. When I set disabledClass to some value, I expect link to have that class. But following code does not work as expected (expected link to have class some-class, in fact it has disabled class and not some-class):

{{#link-to 'parent' tagName='div' class='item' disabled=true disabledClass='some-class'}}
  <div class="header">Menu Item</div>
  <div class="menu">
    {{link-to 'Sub-menu Item 1 ' 'parent.child-1' class='item'}}
    {{link-to 'Sub-menu Item 2 ' 'parent.child-2' class='item'}}
  </div>
{{/link-to}}

And this code works just fine:

{{#link-to 'parent' tagName='div' class='item' disabledClass='some-class' disabled=true}}
  <div class="header">Menu Item</div>
  <div class="menu">
    {{link-to 'Sub-menu Item 1 ' 'parent.child-1' class='item'}}
    {{link-to 'Sub-menu Item 2 ' 'parent.child-2' class='item'}}
  </div>
{{/link-to}}

I think it works this way:

1. classNameBindings contains disabled
2. disabled is defined as a computed property without dependent keys and has a setter which returns disabledClass
3. In first example setter of disabled property is called before disabledClass is changed from default value disabled to some-class

[boris-petrov]

@sandstrom - I just tested this on Ember 3.28.1 and the issue is still there so please do not close the issue.

[sandstrom]

I’m doing some issue gardening 🌱🌿 🌷 and came upon this issue. Since it’s quite old I just wanted to ask if this is still relevant? If it isn’t, maybe we can close this issue?

By closing some old issues we reduce the list of open issues to a more manageable set.