Dynamically created computed property seems to be broken in 3.1

Hello !

I’m using dynamically generated computed property, and it seems to not work anymore in 3.1.

Here is a code sample of what I’m doing :

	setupNormalUser(currentUser) {
		Ember.set(this, "projects",
			Ember.computed("currentUser.projects.[]", "[e-mail]",
				() => {
					let projects = [].concat(currentUser.get("projects"))
					const demoAccounts = this.get("demoAccounts.content")
					if (Ember.isArray(demoAccounts)) {
						demoAccounts.forEach(
							(demoAccount) => projects = projects.concat(demoAccount.get("projects"))
						)
					}
					return projects
				}
			)
		)
		Ember.set(this, "accounts",
			Ember.computed("currentUser.accounts.[]", "projects.[]", function() {
				const projects = currentUser.get("projects") || [];
				return projects
					.filter(project=>!Ember.isNone(project))
					.map(project=>project.get("account.content"))
					.concat( currentUser.get("accounts"))
					.filter(a => !Ember.isNone(a)).uniq()
			})
		)
		Ember.set(this, "assetLibraries",
			Ember.computed("[e-mail]", function() {
				return currentUser.get("accounts").map(
					(account) => account.get("assetLibraries").toArray()
				).reduce(
					(prev, cur) => prev.concat(cur), []
				).uniq()
			})
		)
	},
	setupSuperAdmin(currentUser) {
		this.set("projects", this.get("store").findAll("project"))
		this.set("accounts", this.get("store").findAll("account"))
		this.set("assetLibraries", this.get("store").findAll("assetLibrary"))
	},

[rwjblue]

I’m fairly sure my prior comment is correct, and this is a duplicate of https://github.com/emberjs/ember.js/issues/16427. Essentially doing this:

Ember.set(someObject, Ember.computed('depKey', function() { /* some calculation */ }));

Is not a thing we actually support. The quick solution in your snippet above would be to move from Ember.set to Ember.defineProperty (which works all the way back to Ember 1.x).

Something like this...

setupNormalUser(currentUser) {
		Ember.defineProperty(this, "projects",
			Ember.computed("currentUser.projects.[]", "[e-mail]",
				() => {
					let projects = [].concat(currentUser.get("projects"))
					const demoAccounts = this.get("demoAccounts.content")
					if (Ember.isArray(demoAccounts)) {
						demoAccounts.forEach(
							(demoAccount) => projects = projects.concat(demoAccount.get("projects"))
						)
					}
					return projects
				}
			)
		)
		Ember.defineProperty(this, "accounts",
			Ember.computed("currentUser.accounts.[]", "projects.[]", function() {
				const projects = currentUser.get("projects") || [];
				return projects
					.filter(project=>!Ember.isNone(project))
					.map(project=>project.get("account.content"))
					.concat( currentUser.get("accounts"))
					.filter(a => !Ember.isNone(a)).uniq()
			})
		)
		Ember.defineProperty(this, "assetLibraries",
			Ember.computed("[e-mail]", function() {
				return currentUser.get("accounts").map(
					(account) => account.get("assetLibraries").toArray()
				).reduce(
					(prev, cur) => prev.concat(cur), []
				).uniq()
			})
		)
	},

[olivierchatry]

Closing it, as it was a miss-use of the system.