Ember 2.18 regression - TargetObject refactor breaks action propagation with target property defined

Came across an odd situation trying out 2.18.0-beta.2 in our app where the action we fire to close modals no longer work. I traced it to, I think, this change to how getTarget finds the target of an action. It seems that if the object that invokes the action has a target property defined on it for whatever reason the action gets swallowed.

For our case I traced it to where ember-modal-dialog has a target property on its base component, but I was also able to create this very bare bones twiddle to reproduce the problem. If you comment out the target property on the component in the twiddle you’ll see the action correctly propagate and show an alert but with the property in place clicking the link does nothing.

[rwjblue]

Thanks for reporting. I’m traveling today and likely won’t habe a ton of time to dig in, but it does sound like a regression to me. Thanks for testing beta and reporting before the regression is released!

[sandstrom]

I’m doing some issue gardening 🌱🌿 🌷 and came upon this issue. Since it’s quite old I just wanted to ask if this is still relevant? With the new glimmer / angle bracket components being “the future”, maybe we can close this issue?

By closing some old issues we reduce the list of open issues to a more manageable set.