`transition.retry` broken w/ initial transition on Ember-2.14.0-beta.1
See original GitHub issueHere is a reproduction app: https://github.com/workmanw/router-retry-bug Here is a live demo: https://workmanw.github.io/router-retry-bug
(I couldn’t make a twiddle because it doesn’t seem to support beta builds at the moment)
The issue seems to be that if the initial [first] transition within an ember app is aborted via redirect, then later someone tries to call transition.retry
it doesn’t work as expected. While it does ultimately transition correctly, it doesn’t update the URL. You should be able to easily reproduce this with the live demo above.
I bisected this issue and it seems to be cause by this PR: https://github.com/emberjs/ember.js/pull/15168
CC: @cibernox
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Preventing and Retrying Transitions - Routing - Ember Guides
This gives each active route, starting with the leaf-most route, the opportunity to decide whether or not the transition should occur.
Read more >Transition retry with dynamic segments throws error #10972
On login success, the transition (songs/1?author='Ivan') is retried and the error is thrown. If user does only the first step and reloads the ......
Read more >Router Preventing Transitions Via willTransition - Tutorialspoint
It fires the willTransition action on currently active routes when you re-attempt the transition by using the {{link-to}} helper or the transitionTo method....
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
https://github.com/tildeio/router.js/pull/213 should fix…
Ya, the bug is ultimately over in router.js. It seems like an interaction between https://github.com/tildeio/router.js/pull/211 and https://github.com/tildeio/router.js/pull/197.
It may just be that if the initial transition is aborted, that we change the method from
replace
…@cibernox / @alexspeller - Can one of y’all take a look and help me hash out the right solution?