Unify internal testing styles

Currently there are two different styles that tests are written. An older style which uses a QUnit global to define the module and tests via QUnit.module() and QUnit.test(). The old style also uses globals for the assertion such as ok, equal, etc. A newer style which does not use QUnit globals is partially rolled out in some of the packages. This issue tracks the work needed to move all tests over to the newer style and the related work surrounding it.

A breakdown of how to complete the conversion:

1. QUnit.module becomes moduleFor

// Old Style:
QUnit.module('<MODULE_NAME>');

// New Style:
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';

moduleFor('<MODULE_NAME>', class extends AbstractTestCase {
  //...
});

Note: There are a few test case classes already so check here for other options.

1. QUnit.test becomes a property on the test case class

// Old Style:
QUnit.test('<TEST_NAME>', function() {
  // test case here
});

// New Style:
moduleFor('<MODULE_NAME>', class extends TestCase {
  ['@test <TEST_NAME>'](assert) {
    // test case here
  }
});

1. Assertions should be references off of the callback assert argument

// Bad:
QUnit.test('<TEST_NAME>', function() {
  equal(1, 1);
});

// Bad:
moduleFor('<MODULE_NAME>', class extends TestCase {
  ['@test <TEST_NAME>']() {
    this.assert.equal(1, 1);
  }
});

// Good:
moduleFor('<MODULE_NAME>', class extends TestCase {
  ['@test <TEST_NAME>'](assert) {
    assert.equal(1,1)
  }
});

Below are the packages that need to be converted:

• container (🔒 @t-sauer) https://github.com/emberjs/ember.js/pull/15990
• ember-application (🔒 @locks)
• ember-debug (🔒 @locks) https://github.com/emberjs/ember.js/pull/15998
• ember-metal (🔒 @thoov) https://github.com/emberjs/ember.js/pull/16034 https://github.com/emberjs/ember.js/pull/16036 https://github.com/emberjs/ember.js/pull/16051
• ember-routing (🔒 @thoov) https://github.com/emberjs/ember.js/pull/16015 https://github.com/emberjs/ember.js/pull/16029 https://github.com/emberjs/ember.js/pull/16030 https://github.com/emberjs/ember.js/pull/16072 https://github.com/emberjs/ember.js/pull/16105 https://github.com/emberjs/ember.js/pull/16106
• ember-runtime (🔒 @thoov)
• ember-template-compiler (🔒 @karthiick) https://github.com/emberjs/ember.js/pull/16010
• ember-utils (🔒 @locks) https://github.com/emberjs/ember.js/pull/15997
• internal-test-helpers (🔒 @thoov) https://github.com/emberjs/ember.js/pull/16033
• ember-testing (🔒 @cibernox) https://github.com/emberjs/ember.js/pull/16022
• ember (🔒 @locks) #16019 #16449

Below is the test related cleanup that is needed:

• Move off of QUnit global (🔒 @thoov)
• upgrade to QUnit 2 #16073
• remove testBoth & testWithDefault (🔒 @thoov) #16450

[cibernox]

I can take ember-testing

[pixelhandler]

@Turbo87 @cibernox @karthiicksiva @locks @mikerhyssmith @rwjblue @t-sauer @thoov is this still an issue, perhaps we should close, what do you think?