beta.2 model unit tests failing w/codemod

version ember-cli-qunit 4.1.0-beta.2

Synopsis

Just read @rwjblue blog post and ran the codemod converting the tests to 4.1.0-beta.2 tests API.

I ran codemod incrementally, and most of the codemod changes produced successful converstions with passing tests. Two exceptions are tests/unit/models/* and tests/integration/components/* which are failing.

Here is an example for a model unit test

before codemod:

tests/unit/models/user-test.js

import { moduleForModel, test } from 'ember-qunit';

moduleForModel('user', 'Unit | Model | user', {
  // Specify the other units that are required for this test.
  needs: [
    'validator:confirmation',
    'validator:format',
    'validator:length',
    'validator:presence',
  ],
});

test('it exists', function(assert) {
  let model = this.subject();
  // let store = this.store();
  assert.ok(!!model);
});

after codemod

import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';

module('Unit | Model | user', function(hooks) {
  setupTest(hooks);

  test('it exists', function(assert) {
    let model = this.owner.lookup('service:store').createRecord('user');
    // let store = this.store();
    assert.ok(!!model);
  });
});

error

Error: Assertion Failed: You have turned on testing mode, which disabled the run-loop's autorun. You will need to wrap any code with asynchronous side-effects in a run
    at new EmberError (http://localhost:4200/assets/vendor.js:24282:25)
    at Object.assert (http://localhost:4200/assets/vendor.js:24524:15)
    at Function.run.schedule (http://localhost:4200/assets/vendor.js:37739:76)
    at RecordArrayManager.internalModelDidChange (http://localhost:4200/assets/vendor.js:174641:16)
    at RecordArrayManager.recordDidChange (http://localhost:4200/assets/vendor.js:174616:10)
    at InternalModel.updateRecordArrays (http://localhost:4200/assets/vendor.js:172521:35)
    at InternalModel.transitionTo (http://localhost:4200/assets/vendor.js:172338:10)
    at Object.loadedData (http://localhost:4200/assets/vendor.js:166171:21)
    at InternalModel.send (http://localhost:4200/assets/vendor.js:172225:30)
    at InternalModel.loadedData (http://localhost:4200/assets/vendor.js:172106:10)

repo/branch: https://github.com/mirai-audio/mir/tree/testing-qunit-codemod/tests

[rwjblue]

Awesome, thanks for working through that @0xadada!

[rwjblue]

Awesome, thanks for digging! The specific issue you are hitting with the rendering test is indeed an issue with the ember-test-component addon (see https://github.com/poteto/ember-test-component/issues/6, and https://github.com/poteto/ember-test-component/pull/7).

You can work around (if you want to) via something like this:

module('Integration | Component | ma auth', function(hooks) {
  setupRenderingTest(hooks);

  hooks.beforeEach(function() {
    Ember.setOwner(this, this.owner);
  });

  // .... existing contents ....
});

Note: this is really just a work around until https://github.com/poteto/ember-test-component/pull/7 lands…