Container with position:fixed/absolute is not visible during tests (due to being inside qunit-fixture)
See original GitHub issueThis is my first time filling an issue in this project so please let me know if I need to provide more information.
After recent update to v5.1.1
we got some tests failing.
Basically the setup is container with position:fixed; top:0; right:0; bottom:0; left:0;
that got some content inside. In non test setup its visible, however during tests execution its being reported as isNotVisible()
. Same situation is for position:absolute;
which is probably even more common case.
Tests setup (container is not visible): https://jsfiddle.net/wmgr5467/
Non tests setup (container is visible): https://jsfiddle.net/7jngepau/
Here’s the commit that is the cause. If I disable styling changes introduced in that commit, it fixes the tests.
I saw related conversation going in this PR and I think that custom CSS played bad trick here. Can we consider rolling it back and fixing it in a different way?
Issue Analytics
- State:
- Created 3 years ago
- Reactions:3
- Comments:7 (3 by maintainers)
Top GitHub Comments
@MrChocolatine, this is intentional. Going forward, what was known as the “Dock container” option is now the default layout for the test page. The specific reasoning is due to the way QUnit styling was changed in v2.14.0 to
fixed
positioning. It is no longer possible to maintain the previous layout (where the testing container flowed underneath the test results), without resorting to heavy CSS overrides/hacks. The main issues that have been addressed include:ember-a11y-testing
addon.While it’s not a perfect solution, it’s a pretty good compromise between usability and avoiding regressions for application test suites.
I think it was a problem before that this frame was not having size, that’s why some elements was considered as not visible. Also I can confirm that it fixed initial problem we had in our repo. Thanks @drewlee & @rwjblue