Teardown with App.destroy

I’ve been searching like crazy to nail down this bug, and I think it has to do with qunit setup/teardown.

Loading some embedded records (Responses) on my Entry model like this:

    setup: ->
      App         = startApp()
      store       = App.__container__.lookup("store:main")
      controller  = @subject()

      Ember.run ->
        store.pushPayload "entry", entryFixture
        controller.set('model', store.find('entry', entryFixture.entry.id))

    teardown: -> Ember.run(App, App.destroy)

And it works fine running a single test, but on running whole suite the first one passes then I get the following:

Setup failed on Generates #sections from catalog_definitions: Assertion Failed: Expected an object as `data` in a call to `push`/`update` for flaredown@model:response: , but was <flaredown@model:response::ember387:hbi_general_wellbeing_fd088f9929639fd742a209b4b083c421>
Source:     
Error: Assertion Failed: Expected an object as `data` in a call to `push`/`update` for flaredown@model:response: , but was <flaredown@model:response::ember387:hbi_general_wellbeing_fd088f9929639fd742a209b4b083c421>
    at new Error (native)
    at Error.EmberError (http://localhost:4300/assets/vendor.js:27425:23)
    at Object.Ember.assert (http://localhost:4300/assets/vendor.js:17039:15)
    at Ember.Object.extend.push (http://localhost:4300/assets/vendor.js:75059:15)
    at http://localhost:4300/assets/vendor.js:66195:15
    at Array.forEach (native)
    at forEach (http://localhost:4300/assets/vendor.js:27206:32)
    at extractEmbeddedHasMany (http://localhost:4300/assets/vendor.js:66193:7)
    at http://localhost:4300/assets/vendor.js:66172:15
    at http://localhost:4300/assets/vendor.js:73146:20

It seems Ember.run(App, App.destroy) is not sufficient reset the test environment back to zero? What else might need to happen here?

[hadsy]

Hey @atomkirk, here is a useful link describing the shared state issue when using arrays. https://dockyard.com/blog/2015/09/18/ember-best-practices-avoid-leaking-state-into-factories

We had similar issues with tests and moved all array initialisation in to init()

[timohermans]

@alvinvogelzang Thanks for the suggestion. This was indeed how we fixed it in our application, except we did in the setupController hook. Thanks!