Could not find module ember-get-config imported from (require)

Hello. I am trying to migrate Ember app to Embroider and I am getting this error from several addon packages:

• ember-cli-moment-shim
• ember-drag-drop-polyfill

I am using Ember 3.26 and Embroider 0.41.0

[ef4]

It’s possible to disable a built in compat adapter if it’s causing trouble. You set the compatAdapters option to a Map where the name of the addon maps to null.

On Mon, May 24, 2021 at 8:38 AM Maksym Shcherban @.***> wrote:

@alexlafroscia https://github.com/alexlafroscia it seems this error might be caused by ember-get-config compat adapter that you wrote in #770 https://github.com/embroider-build/embroider/pull/770. I have tried removing it from my @.**/compat/src/ember-get-config. and now my application loads perfectly fine. What could be the reason for that? If you have time, can you please look into this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/embroider-build/embroider/issues/823#issuecomment-847013739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACN6MTYON2U3P4UZFZXZJDTPJCCRANCNFSM45ND5Q3Q .

[alexlafroscia]

The compat adapter was created originally because ember-get-config generates (or did, at the time that I wrote it) a module that itself depends on your host app without actually listing it as a dependency. This kind of implicit dependency on a module – especially when that module is the host app – isn’t valid.

When talking through that fact with @ef4, it was suggested that we use a compat adapter to generate a different implementation with the same outcome, that doesn’t require the addon depending on the host app.

It’s possible ember-get-config has updated to no longer do that, or do it in a safer way.

What kind of error did you see?