Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

hbs-loader incompatible with components named `Link`

See original GitHub issue

Example error:

ERROR in ../../engines/labor-employee-engine/components/shift-day.hbs
Module Error (from ../../../../../../../../../../../Users/runspired/github/private/fnb/node_modules/@embroider/hbs-loader/src/index.js):
(Emitted value instead of an instance of Error) SyntaxError: Closing tag </div> did not match last open tag <Link> (on line 24):

The issue here I think is that something the loader is using is confusing <Link></Link> for the element <link />. Capitalization needs to be taken into account.

Issue Analytics

State:
Created a year ago
Comments:9 (4 by maintainers)

Top GitHub Comments

2reactions

ef4commented, Apr 4, 2022

This matters for Embroider because we rewrite all v1-formatted addons to v2-format (so that subsequent build stages can be in a pure v2 world and be much simpler). One thing we do during that rewriting is run any custom transforms. That means that templates get parsed and re-printed. So a bugs in the printer effect us in a way that doesn’t matter in classic builds.

This bug only happens in v1 addons. In app code, it shouldn’t occur. And in v2 addons it shouldn’t occur. It’s only the compat layer for v1 addons that relies on the glimmer AST printer.

1reaction

ef4commented, Apr 5, 2022

I think this bug might apply to all these names:

area
base
br
col
command
embed
hr
img
input
keygen
link
meta
param
source
track
wbr

https://github.com/glimmerjs/glimmer-vm/blob/07db0655c8d4b5c71792bf49ba3b547c196e460a/packages/%40glimmer/syntax/lib/generation/printer.ts#L9

based off investigation by @Windvis.

Top Results From Across the Web

@embroider/hbs-loader | Yarn - Package Manager

This repo implements a new three-stage build system for Ember apps: The first stage achieves backward compatibility by building each classic Ember Addon...

vuepress-html-webpack-plugin

Simplifies creation of HTML files to serve your webpack bundles. Latest version: 3.2.0, last published: 4 years ago.

<af:link>

Name Type Supports EL? accessKey char Yes action javax.el.MethodExpression Yes actionListener javax.faces.el.MethodBinding Only EL

more plugin - OSCHINA - 中文开源技术交流社区

... you can link screens together, add interactions and animations. Export Colors, by Massimo Cassandro: Export document color components Fake News, ...

embroider - bytemeta

hbs-loader incompatible with components named `Link`. simonihmig. simonihmig OPEN · Updated 3 months ago · v2 addon files not resolvable when brought into ......