Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Should Embroider passthrough script attributes?

See original GitHub issue

Hi,

should Embroider passthrough the HTML attributes like defer on scripts from app/index.html into dist/index.html for ember build --environment=production?

<!-- app/index.html -->
<script src="{{rootURL}}assets/vendor.js" defer></script>
<script src="{{rootURL}}assets/embroider-playground.js" defer></script>

<!-- dist/index.html -->
<script src="/assets/vendor.js"></script>
<script src="/assets/chunk.c1fdfc6b793b9d023c96.js"></script>
<script src="/assets/chunk.4aecffffbd029f26d4de.js"></script>

Thanks ☺️

Just for curiosity why the assets/embroider-playground.js is split into two chunks by default?

Issue Analytics

State:
Created 3 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

lifeartcommented, Jan 11, 2022

Hi @rahulk94! I think only tests is missing in original PR to move it forward

1reaction

ef4commented, May 19, 2020

Oops, never mind me, I was mixed up with async.

Top Results From Across the Web

embroider/ember-webpack.ts at main - GitHub

embroider /ember-webpack.ts at main · embroider-build/embroider. ... zero here means we always attribute passthrough scripts to the. // first build variant.

v2 Addon Format (Embroider Compatibility) - Ember RFCs

Implicit Dependencies: scripts, modules, and stylesheets that should be implicitly included in the app or the app's tests whenever this addon is ...

The Script element - HTML: HyperText Markup Language

This attribute allows the elimination of parser-blocking JavaScript where the browser would have to load and evaluate scripts before continuing ...

About Annex Sports & Trophy Center | Logansport, IN Trophies

Annex Sports & Trophy Center provides custom screen printing, embroidery, trophies, plaques, awards, signs, banners and more to the Logansport, ...

Basehor, KS Embroidery - About House of Apparel

Our automated screen printing presses, multiple embroidery machines and highly ... We can outfit you with custom printed T-shirts, hoodies, sweatshirts, ...