Tracking Issue [Test Failures]

This is an issue to help keep track of/coordinate/ultimately resolve test failures seen. @rwjblue and myself are pairing on this, and we using this issue to keep track of what is up.

Reproduction:

cd embroider/test-packages/macro-sample-addon
yarn test

Results in:

scenario	entry status	TL;DR	current status
ember-lts-2.16	✅		✅
ember-lts-2.20	❌	TypeError: block is not iterable	proposed fix https://github.com/embroider-build/embroider/pull/839/
ember-lts-2.24	❌	TypeError: block is not iterable	proposed fix https://github.com/embroider-build/embroider/pull/839/
ember-release	❌	Uncaught ReferenceError: Ember is not defined	✅fix landed
ember-beta	❌	Uncaught ReferenceError: Ember is not defined	✅fix landed
ember-canary	❌	Uncaught ReferenceError: Ember is not defined	✅fix landed

Issues

At first glance, it appears we have two different issues:

1) block is not iterable

Maybe a template compiler iter-opt issue which appears to be at-play for LTS 2.20 -> LTS 2.24, we haven’t ruled out it isn’t effecting ember-release/ember-beta/ember-canary yet, but as those are failing for other reasons we do not yet know for sure they are not effected.

2) Ember is not defined

Maybe ember’s boot-straping of window.Ember isn’t running, this appears to effect ember-* scenarios.

Potentially related to: https://github.com/emberjs/ember.js/commit/de777ec921b21e5760284fa6e5a0f5bc7d6d144d / https://github.com/emberjs/ember.js/pull/19557

[stefanpenner]

I have posted a PR which addresses my understanding of the last issue: https://github.com/embroider-build/embroider/pull/839/

It also exposes two more currently undiscovered issues, related to the same problem, which I intend to follow up with fixes on next.

[rwjblue]

Working on fixing this over in https://github.com/emberjs/ember.js/pull/19586, that will reset the boostrapping back to an IIFE and restore functionality for Embroider 0.40 and 0.41 (without requiring changes in Embroider).