Feature request: Expose security framework result code when throwing error

Hi there,

We saw a huge spike in Sentry about an error that this package throws on iOS. It’s weird since we haven’t upgrade this package. We did upgrade react native to 0.62.2 though.

Error getItem(react-native/Libraries/BatchedBridge/NativeModules) An error occured while retrieving value

I know this can happen, and it’s our mistake of not handling the error properly.

But, it would be very handy if the result code was shown in that error as well. That way we have a starting point for debugging purposes, since it’s not on a specific device, nor a specific iOS version, and it only started happening on our latest release.

[emeraldsanto]

I’ve got the code up and running locally, I’ve tested by rejecting with arbitrary OSStatus members such as errSecNoSuchKeychain and the equivalent code (-25294) was sent back to JS in the error.code property. I then used osstatus.com to search for the code and check if the results matched the native error.

This experiment was successful and you can expect a release tomorrow morning, or rather afternoon in Belgium 😅

[emeraldsanto]

Hi! I’ve also been using this in production for a while now without this kind of incident. I’m sorry to hear that you’ve been facing some problems using this library.

I can definitely look into forwarding this kind of info though. I’m wondering if the base AsyncStorage module does this or not.

Regardless, it should be an easy fix and I’ll try to release a new version in the upcoming days.