Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bump RegistraionsBaseUrl to 3.6.0

See original GitHub issue

Sleet supports Semver 2 versions. Should the RegistrationsBaseUrl be bumped from 3.4.0 to 3.6.0?

https://github.com/emgarten/Sleet/blob/51b0b8b0b739e17a18627003358d18a3e84e6956/src/SleetLib/Commands/InitCommand.cs#L89

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

emgartencommented, Jun 20, 2018

I don’t see any difference in how Paket handles the different versions. Since Sleet only contains one registration url it is going to get the same result regardless of the version. https://github.com/fsprojects/Paket/blob/035545c1de9851d0c85801abd43d0f24ee384479/src/Paket.Core/Dependencies/NuGetV3.fs#L59-L60

Here is the relevant code where it is set in Sleet: https://github.com/emgarten/Sleet/blob/50df09d7e54c6ad9e75a8faa797e91dbf22a054b/src/SleetLib/Commands/InitCommand.cs#L89

Packages.config for NuGet 3.4.x would could be impacted if the user adds SemVer 2.0.0 packages to a feed. But if the version were bumped to 3.6.0 the 3.4.x client wouldn’t be able to read the feed at all, even if all packages were SemVer 1.0.0.

Looking through the stats on nuget.org it doesn’t look like there is much usage for 3.4.x still. Most users are on 3.6.0+ or are using 3.3.0 which wouldn’t work with Sleet today.

I’m willing to accept a PR for this if you want to make the change. It would be more correct to use 3.6.0.

0reactions

emgartencommented, Jun 25, 2018

Closing this out per the discussion in the PR.

Top Results From Across the Web

Package Metadata, NuGet API

The package registration base URL allows fetching metadata about packages.

cy.request does not work with followRedirect: false and Set ...

No problems on 3.6.0. Direct requests work fine, but as soon as you start using options and path, it breaks. This request is...

tsconfig-paths

Config loading process ... Use process.env.TS_NODE_PROJECT to resolve tsConfig.json and the specified baseUrl and paths. Resolves tsconfig.json from current ...

Elastic Cloud Enterprise 2.12.3

Bump timeouts and add logging. The ECE installer --timeout-factor CLI argument has been improved so that it applies to more potential timeout scenarios...

Extension Migration Guide - JupyterLab Documentation

With JupyterLab 4.x, the npm package version policy changed to not bump major version with the Python package unless required to ease extension...