Adding support for promises

I’d like to request support for the Promise API. Your code example together with async / await would look like following then.

const securePassword = require('secure-password')

// Initialise our password policy
const pwd = securePassword()

const doHashingAndVerify = async function () {
  const userPassword = Buffer.from('my secret password')

  // Register user
  const hash = await pwd.hash(userPassword) 

  // Save hash somewhere
  const result = await pwd.verify(userPassword, hash)

  if (result === securePassword.INVALID) return console.log('Imma call the cops')
  if (result === securePassword.VALID) return console.log('Yay you made it')
  if (result === securePassword.VALID_NEEDS_REHASH) {
    console.log('Yay you made it, wait for us to improve your safety')

    const improvedHash = await pwd.hash(userPassword)
  }
}

doHashingAndVerify()
  .then(() => console.log('succesful'))
  .catch(err => throw err)

Really enjoyed your JSConf talk btw!

[watson]

Instead of a wrapper which needs to be maintained, wouldn’t it be easier to simply promisify the module in your code via util.promisify?

[emilbayes]

@mrksbnch It seems that util.promisify changes the context of the wrapped function, so that this no longer references the securePassword instance (the this part here), and instead refers to the global scope. I don’t know much about promises or how promisify works, but it seems that the issue lies here, where original is called with a this, which in that context refers to the global scope:

https://github.com/nodejs/node/blob/1c28dfa09a443bab9f72fd1d89a4f645de8c5a42/lib/internal/util.js#L229